Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f323b80d authored by Bartlomiej Zolnierkiewicz's avatar Bartlomiej Zolnierkiewicz
Browse files

ide: sanitize SELECT_MASK() usage in ide_driveid_update() 



Call SELECT_MASK() after ide_fix_driveid().

Signed-off-by: default avatarBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
parent 1bd4c1f4

drivers/ide/ide-iops.c

+3 −1
Original line number Diff line number Diff line
@@ -340,13 +340,15 @@ int ide_driveid_update(ide_drive_t *drive) 
	}



	local_irq_save(flags);

	SELECT_MASK(drive, 0);

	tp_ops->input_data(drive, NULL, id, SECTOR_SIZE);

	(void)tp_ops->read_status(hwif);	/* clear drive IRQ */

	local_irq_enable();

	local_irq_restore(flags);



	ide_fix_driveid(id);



	SELECT_MASK(drive, 0);



	drive->id[ATA_ID_UDMA_MODES]  = id[ATA_ID_UDMA_MODES];

	drive->id[ATA_ID_MWDMA_MODES] = id[ATA_ID_MWDMA_MODES];

	drive->id[ATA_ID_SWDMA_MODES] = id[ATA_ID_SWDMA_MODES];