Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f2e2e35b authored by Karthik Reddy Katta's avatar Karthik Reddy Katta Committed by Gerrit - the friendly Code Review server
Browse files

ASoC: msm: qdsp6v2: Fix memory allocation issues in audio_cal_utils 



Incorrect pointer is used while allocating memory
for 'cal_block' pointer. Use proper pointer in kzalloc().

Memory of 'cal_block->cal_info' is not initialized to ZERO.
Use kzalloc() instead of kmalloc() to initialize this memory.

CRs-Fixed: 983585
Change-Id: Ifbe1d91d68da81d058197af2a403c4b832b019fb
Signed-off-by: default avatarKarthik Reddy Katta <a_katta@codeaurora.org>
parent fdabe34a

sound/soc/msm/qdsp6v2/audio_cal_utils.c

+2 −3
Original line number Diff line number Diff line
@@ -595,14 +595,13 @@ static struct cal_block_data *create_cal_block(struct cal_type_data *cal_type, 
		goto done;

	}



	cal_block = kmalloc(sizeof(*cal_type),

	cal_block = kzalloc(sizeof(*cal_block),

		GFP_KERNEL);

	if (cal_block == NULL) {

		pr_err("%s: could not allocate cal_block!\n", __func__);

		goto done;

	}



	memset(cal_block, 0, sizeof(*cal_block));

	INIT_LIST_HEAD(&cal_block->list);

	list_add_tail(&cal_block->list, &cal_type->cal_blocks);
@@ -627,7 +626,7 @@ static struct cal_block_data *create_cal_block(struct cal_type_data *cal_type, 
				client_info_size);

	}



	cal_block->cal_info = kmalloc(

	cal_block->cal_info = kzalloc(

		get_cal_info_size(cal_type->info.reg.cal_type),

		GFP_KERNEL);

	if (cal_block->cal_info == NULL) {