Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f2e06c58 authored by NeilBrown's avatar NeilBrown
Browse files

md/bitmap: remove confusing code from filemap_get_page. 



file_page_index(store, 0) is *always* 0.
This is because the bitmap sb, at 256 bytes, is *always* less than
one page.
So subtracting it has no effect and the code should be removed.

Reported-by: default avatarGoldwyn Rodrigues <rgoldwyn@suse.de>
Signed-off-by: default avatarNeilBrown <neilb@suse.de>
parent cf170f3f

drivers/md/bitmap.c

+1 −5
Original line number Diff line number Diff line
@@ -669,17 +669,13 @@ static inline unsigned long file_page_offset(struct bitmap_storage *store, 
/*

 * return a pointer to the page in the filemap that contains the given bit

 *

 * this lookup is complicated by the fact that the bitmap sb might be exactly

 * 1 page (e.g., x86) or less than 1 page -- so the bitmap might start on page

 * 0 or page 1

 */

static inline struct page *filemap_get_page(struct bitmap_storage *store,

					    unsigned long chunk)

{

	if (file_page_index(store, chunk) >= store->file_pages)

		return NULL;

	return store->filemap[file_page_index(store, chunk)

			      - file_page_index(store, 0)];

	return store->filemap[file_page_index(store, chunk)];

}



static int bitmap_storage_alloc(struct bitmap_storage *store,