Commit f2a6fed1 authored Jul 22, 2013 by Dan Carpenter Committed by Greg Kroah-Hartman Jul 23, 2013

staging: gdm72xx: potential use after free in send_qos_list()

Sometimes free_qos_entry() sometimes frees its argument. I have moved
the dereference of "entry" ahead on line to avoid a use after free.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 3a349cee

drivers/staging/gdm72xx/gdm_qos.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -250,8 +250,8 @@ static void send_qos_list(struct nic nic, struct list_head head)

		list_for_each_entry_safe(entry, n, head, list) {
		list_del(&entry->list);
		free_qos_entry(entry);
		gdm_wimax_send_tx(entry->skb, entry->dev);
		free_qos_entry(entry);
		}
		}