Commit f27c95db authored Aug 06, 2014 by Joe Perches Committed by Linus Torvalds Aug 06, 2014

checkpatch: improve "no space after cast" test



This --strict test previously worked only for what appeared to be cast
to pointer types.

Make it work for all casts.

Also, there's no reason to show the previous line for this type of
message, so don't.

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 1574a29f

scripts/checkpatch.pl

+3 −3

Original line number	Diff line number	Diff line
		@@ -2260,12 +2260,12 @@ sub process {
		}
		}

		if ($line =~ /^\+.\[ \t]*\)[ \t]+(?!$Assignment\|$Arithmetic)/) {
		if ($line =~ /^\+.$\s$Type\s*$[ \t]+(?!$Assignment\|$Arithmetic)/) {
		if (CHK("SPACING",
		"No space is necessary after a cast\n" . $hereprev) &&
		"No space is necessary after a cast\n" . $herecurr) &&
		$fix) {
		$fixed[$linenr - 1] =~
		s/^(\+.\[ \t]*\))[ \t]+/$1/;
		s/($\s$Type\s$)[ \t]+/$1/;
		}
		}