Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f24062b0 authored by Nicolas Dichtel's avatar Nicolas Dichtel Committed by David S. Miller
Browse files

ipv6: fix a refcnt leak with peer addr 



There is no reason to take a refcnt before deleting the peer address route.
It's done some lines below for the local prefix route because
inet6_ifa_finish_destroy() will release it at the end.
For the peer address route, we want to free it right now.

This bug has been introduced by commit
caeaba79 ("ipv6: add support of peer address").

Signed-off-by: default avatarNicolas Dichtel <nicolas.dichtel@6wind.com>
Acked-by: default avatarHannes Frederic Sowa <hannes@stressinduktion.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c199105d

net/ipv6/addrconf.c

+2 −5
Original line number Diff line number Diff line
@@ -4772,12 +4772,9 @@ static void __ipv6_ifa_notify(int event, struct inet6_ifaddr *ifp) 


			rt = rt6_lookup(dev_net(dev), &ifp->peer_addr, NULL,

					dev->ifindex, 1);

			if (rt) {

				dst_hold(&rt->dst);

				if (ip6_del_rt(rt))

			if (rt && ip6_del_rt(rt))

				dst_free(&rt->dst);

		}

		}

		dst_hold(&ifp->rt->dst);



		if (ip6_del_rt(ifp->rt))