Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f24049f4 authored by Tyler Hicks's avatar Tyler Hicks Committed by Greg Kroah-Hartman
Browse files

irda: Only insert new objects into the global database via setsockopt



The irda_setsockopt() function conditionally allocates memory for a new
self->ias_object or, in some cases, reuses the existing
self->ias_object. Existing objects were incorrectly reinserted into the
LM_IAS database which corrupted the doubly linked list used for the
hashbin implementation of the LM_IAS database. When combined with a
memory leak in irda_bind(), this issue could be leveraged to create a
use-after-free vulnerability in the hashbin list. This patch fixes the
issue by only inserting newly allocated objects into the database.

CVE-2018-6555

Fixes: 1da177e4 ("Linux-2.6.12-rc2")
Signed-off-by: default avatarTyler Hicks <tyhicks@canonical.com>
Reviewed-by: default avatarSeth Arnold <seth.arnold@canonical.com>
Reviewed-by: default avatarStefan Bader <stefan.bader@canonical.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 9f0547e0
Loading
Loading
Loading
Loading
+5 −1
Original line number Diff line number Diff line
@@ -2051,7 +2051,11 @@ static int irda_setsockopt(struct socket *sock, int level, int optname,
			err = -EINVAL;
			goto out;
		}

		/* Only insert newly allocated objects */
		if (free_ias)
			irias_insert_object(ias_obj);

		kfree(ias_opt);
		break;
	case IRLMP_IAS_DEL: