Commit f17d9f15 authored Jul 21, 2015 by Joe Stringer Committed by Sasha Levin Oct 27, 2015

netfilter: nf_conntrack: Support expectations in different zones



[ Upstream commit 4b31814d20cbe5cd4ccf18089751e77a04afe4f2 ]

When zones were originally introduced, the expectation functions were
all extended to perform lookup using the zone. However, insertion was
not modified to check the zone. This means that two expectations which
are intended to apply for different connections that have the same tuple
but exist in different zones cannot both be tracked.

Fixes: 5d0aa2cc (netfilter: nf_conntrack: add support for "conntrack zones")
Signed-off-by: Joe Stringer <joestringer@nicira.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>

parent 3ad1bd82

net/netfilter/nf_conntrack_expect.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -219,7 +219,8 @@ static inline int expect_clash(const struct nf_conntrack_expect *a,
		a->mask.src.u3.all[count] & b->mask.src.u3.all[count];
		}

		return nf_ct_tuple_mask_cmp(&a->tuple, &b->tuple, &intersect_mask);
		return nf_ct_tuple_mask_cmp(&a->tuple, &b->tuple, &intersect_mask) &&
		nf_ct_zone(a->master) == nf_ct_zone(b->master);
		}

		static inline int expect_matches(const struct nf_conntrack_expect *a,