Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f12919d5 authored by Elena Oat's avatar Elena Oat Committed by Greg Kroah-Hartman
Browse files

Staging: rtl8188eu: Fix warning of unchecked sscanf return value. 



This patch fixes the warning "unchecked sscanf return value" in file
rtw_mp.c. Zero is returned in case sscanf fails or if less than expected
items are read and assigned successfully. I have decided to return zero,
because in previous conditional statements zero was returned in case of
failure.

While at it, I have also fixed the warning of line over 80
characters.

Signed-off-by: default avatarElena Oat <oat.elena@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 94b9c616

drivers/staging/rtl8188eu/core/rtw_mp.c

+5 −2
Original line number Diff line number Diff line
@@ -883,7 +883,7 @@ u32 mp_query_psd(struct adapter *pAdapter, u8 *data) 
{

	u32 i, psd_pts = 0, psd_start = 0, psd_stop = 0;

	u32 psd_data = 0;



	int ret;



	if (!netif_running(pAdapter->pnetdev)) {

		RT_TRACE(_module_mp_, _drv_warning_, ("mp_query_psd: Fail! interface not opened!\n"));
@@ -900,7 +900,10 @@ u32 mp_query_psd(struct adapter *pAdapter, u8 *data) 
		psd_start = 64;

		psd_stop = 128;

	} else {

		sscanf(data, "pts =%d, start =%d, stop =%d", &psd_pts, &psd_start, &psd_stop);

		ret = sscanf(data, "pts =%d, start =%d, stop =%d",

				&psd_pts, &psd_start, &psd_stop);

		if (ret != 3)

			return 0;

	}



	_rtw_memset(data, '\0', sizeof(*data));