Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f07af4b6 authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman
Browse files

USB: wusbcore/wa-xfer: error handling fixes in setup_segs() 



1) It didn't free xfer->seg[0] so there was a leak.
2) xfer->seg[cnt] can be NULL.
3) Use usb_free_urb() for ->dto_urb instead of kfree().

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 4d2079c1

drivers/usb/wusbcore/wa-xfer.c

+3 −3
Original line number Diff line number Diff line
@@ -695,9 +695,9 @@ error_dto_alloc: 
	cnt--;

error_seg_kzalloc:

	/* use the fact that cnt is left at were it failed */

	for (; cnt > 0; cnt--) {

		if (xfer->is_inbound == 0)

			kfree(xfer->seg[cnt]->dto_urb);

	for (; cnt >= 0; cnt--) {

		if (xfer->seg[cnt] && xfer->is_inbound == 0)

			usb_free_urb(xfer->seg[cnt]->dto_urb);

		kfree(xfer->seg[cnt]);

	}

error_segs_kzalloc: