Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f055663c authored by Andy Whitcroft's avatar Andy Whitcroft Committed by Linus Torvalds
Browse files

checkpatch: report the correct lines for single statement blocks 



Report the correct lines for single statement blocks.  Currently we are
reporting the right number of lines, but not skipping the negative lines.

Signed-off-by: default avatarAndy Whitcroft <apw@shadowen.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 2a1bc5d5

scripts/checkpatch.pl

+3 −3
Original line number Diff line number Diff line
@@ -2214,10 +2214,10 @@ sub process { 
			}

			if ($level == 0 && $block =~ /^\s*\{/ && !$allowed) {

				my $herectx = $here . "\n";;

				my $end = $linenr + statement_rawlines($block) - 1;

				my $cnt = statement_rawlines($block);



				for (my $ln = $linenr - 1; $ln < $end; $ln++) {

					$herectx .= $rawlines[$ln] . "\n";;

				for (my $n = 0; $n < $cnt; $n++) {

					$herectx .= raw_line($linenr, $n) . "\n";;

				}



				WARN("braces {} are not necessary for single statement blocks\n" . $herectx);