Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f012f758 authored by Julia Lawall's avatar Julia Lawall Committed by John W. Linville
Browse files

rt2x00: use ether_addr_equal_64bits 

Ether_addr_equal_64bits is more efficient than ether_addr_equal, and can be
used when each argument is an array within a structure that contains at
least two bytes of data beyond the array.

The structures involved are:
ieee80211_bar defined in include/linux/ieee80211.h and
rt2x00_bar_list_entry defined in drivers/net/wireless/rt2x00/rt2x00.h.

This was done using Coccinelle (http://coccinelle.lip6.fr/

).

Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Acked-by: default avatarGertjan van Wingerde <gwingerde@gmail.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 78c8a950

drivers/net/wireless/rt2x00/rt2x00dev.c

+2 −2
Original line number Original line Diff line number Diff line
@@ -565,10 +565,10 @@ static void rt2x00lib_rxdone_check_ba(struct rt2x00_dev *rt2x00dev, 




#undef TID_CHECK

#undef TID_CHECK





		if (!ether_addr_equal(ba->ra, entry->ta))

		if (!ether_addr_equal_64bits(ba->ra, entry->ta))

			continue;

			continue;





		if (!ether_addr_equal(ba->ta, entry->ra))

		if (!ether_addr_equal_64bits(ba->ta, entry->ra))

			continue;

			continue;





		/* Mark BAR since we received the according BA */

		/* Mark BAR since we received the according BA */