Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f00c401b authored by Horms's avatar Horms Committed by David S. Miller
Browse files

[IPV4]: Remove suprious use of goto out: in icmp_reply 



This seems to be an artifact of the follwoing commit in February '02.

e7e173af42dbf37b1d946f9ee00219cb3b2bea6a

In a nutshell, goto out and return actually do the same thing,
and both are called in this function. This patch removes out.

Signed-Off-By: default avatarHorms <horms@verge.net.au>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 95f7daf1

net/ipv4/icmp.c

+1 −2
Original line number Original line Diff line number Diff line
@@ -385,7 +385,7 @@ static void icmp_reply(struct icmp_bxm *icmp_param, struct sk_buff *skb) 
	u32 daddr;

	u32 daddr;





	if (ip_options_echo(&icmp_param->replyopts, skb))

	if (ip_options_echo(&icmp_param->replyopts, skb))

		goto out;

		return;





	if (icmp_xmit_lock())

	if (icmp_xmit_lock())

		return;

		return;
@@ -416,7 +416,6 @@ static void icmp_reply(struct icmp_bxm *icmp_param, struct sk_buff *skb) 
	ip_rt_put(rt);

	ip_rt_put(rt);

out_unlock:

out_unlock:

	icmp_xmit_unlock();

	icmp_xmit_unlock();

out:;

}

}