Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f009627b authored by Andrew Morton's avatar Andrew Morton Committed by David S. Miller
Browse files

drivers-net-tulip-de4x5c-fix-copy-length-in-de4x5_ioctl-checkpatch-fixes 



ERROR: trailing statements should be on next line
#23: FILE: drivers/net/tulip/de4x5.c:5477:
+	if (copy_to_user(ioc->data, tmp.lval, ioc->len)) return -EFAULT;

total: 1 errors, 0 warnings, 8 lines checked

./patches/drivers-net-tulip-de4x5c-fix-copy-length-in-de4x5_ioctl.patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: Dan Rosenberg <dan.j.rosenberg@gmail.com>
Cc: Grant Grundler <grundler@parisc-linux.org>
Cc: Jeff Mahoney <jeffm@suse.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent a8cb16dd

drivers/net/tulip/de4x5.c

+2 −1
Original line number Diff line number Diff line
@@ -5474,7 +5474,8 @@ de4x5_ioctl(struct net_device *dev, struct ifreq *rq, int cmd) 
	tmp.lval[6] = inl(DE4X5_STRR); j+=4;

	tmp.lval[7] = inl(DE4X5_SIGR); j+=4;

	ioc->len = j;

	if (copy_to_user(ioc->data, tmp.lval, ioc->len)) return -EFAULT;

	if (copy_to_user(ioc->data, tmp.lval, ioc->len))

		return -EFAULT;

	break;



#define DE4X5_DUMP              0x0f /* Dump the DE4X5 Status */