Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit effda697 authored by Martin Berglund's avatar Martin Berglund Committed by Greg Kroah-Hartman
Browse files

staging: vt6655: wpactl.c: Fix sparse warnings 



Add missing __user macro casting in the function wpa_set_keys.
This is okay since the function handles the possibility of
param->u.wpa_key.key and param->u.wpa_key.seq pointing to
kernelspace using a flag, fcpfkernel.

Signed-off-by: default avatarMartin Berglund <martin@rogsta.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 2160e944

drivers/staging/vt6655/wpactl.c

+6 −2
Original line number Diff line number Diff line
@@ -224,7 +224,9 @@ int wpa_set_keys(PSDevice pDevice, void *ctx, 
	} else {

		spin_unlock_irq(&pDevice->lock);

		if (param->u.wpa_key.key &&

		    copy_from_user(&abyKey[0], param->u.wpa_key.key, param->u.wpa_key.key_len)) {

		    copy_from_user(&abyKey[0],

				   (void __user *)param->u.wpa_key.key,

				   param->u.wpa_key.key_len)) {

			spin_lock_irq(&pDevice->lock);

			return -EINVAL;

		}
@@ -262,7 +264,9 @@ int wpa_set_keys(PSDevice pDevice, void *ctx, 
	} else {

		spin_unlock_irq(&pDevice->lock);

		if (param->u.wpa_key.seq &&

		    copy_from_user(&abySeq[0], param->u.wpa_key.seq, param->u.wpa_key.seq_len)) {

		    copy_from_user(&abySeq[0],

				   (void __user *)param->u.wpa_key.seq,

				   param->u.wpa_key.seq_len)) {

			spin_lock_irq(&pDevice->lock);

			return -EINVAL;

		}