Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit eec66731 authored by Jacob Keller's avatar Jacob Keller Committed by Jeff Kirsher
Browse files

ixgbe: add comment noting recalculation of queues 



Since we previously called ixgbe_set_num_queues just prior to attempting
to set our interrupt scheme, it may be non obvious why we have to call
it again inside the function. Add a comment which helps make it more
obvious that we are resetting features based on the fact that we do not
have MSI-X enabled, and cannot use the previous settings.

Signed-off-by: default avatarJacob Keller <jacob.e.keller@intel.com>
Tested-by: default avatarPhil Schmitt <phillip.j.schmitt@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent b8a2ca19

drivers/net/ethernet/intel/ixgbe/ixgbe_lib.c

+8 −0
Original line number Diff line number Diff line
@@ -1086,6 +1086,11 @@ static void ixgbe_set_interrupt_capability(struct ixgbe_adapter *adapter) 
			return;

	}



	/* At this point, we do not have MSI-X capabilities. We need to

	 * reconfigure or disable various features which require MSI-X

	 * capability.

	 */



	/* disable DCB if number of TCs exceeds 1 */

	if (netdev_get_num_tc(adapter->netdev) > 1) {

		e_err(probe, "num TCs exceeds number of queues - disabling DCB\n");
@@ -1107,6 +1112,9 @@ static void ixgbe_set_interrupt_capability(struct ixgbe_adapter *adapter) 
	/* disable RSS */

	adapter->ring_feature[RING_F_RSS].limit = 1;



	/* recalculate number of queues now that many features have been

	 * changed or disabled.

	 */

	ixgbe_set_num_queues(adapter);

	adapter->num_q_vectors = 1;