Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ee7e1ac9 authored by Fred Oh's avatar Fred Oh
Browse files

ASoC: msm: qdsp6v2: fix increasing num_of_popp index twice 



This is a bug increasing number of popp twice and easily reaching MAX
value. num_of_popp is used as index to access array, it may cause memory
out of bounce also.

Change-Id: I5a65b660ccb53fb0e546e767ac641b22382518ed
Signed-off-by: default avatarFred Oh <fred@codeaurora.org>
parent 0c37cc25

sound/soc/msm/qdsp6v2/rtac.c

+1 −1
Original line number Diff line number Diff line
@@ -375,7 +375,7 @@ void add_popp(u32 dev_idx, u32 port_id, u32 popp_id) 
	rtac_adm_data.device[dev_idx].popp[

		rtac_adm_data.device[dev_idx].num_of_popp].popp = popp_id;

	rtac_adm_data.device[dev_idx].popp[

		rtac_adm_data.device[dev_idx].num_of_popp++].popp_topology =

		rtac_adm_data.device[dev_idx].num_of_popp].popp_topology =

		q6asm_get_asm_topology(popp_id);

	rtac_adm_data.device[dev_idx].popp[

		rtac_adm_data.device[dev_idx].num_of_popp++].app_type =