Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ed43b47b authored by Eric Bénard's avatar Eric Bénard Committed by Greg Kroah-Hartman
Browse files

n_gsm: fix UIH control byte : P bit should be 0 



* the GSM 07.10 specification says in 5.4.3.1 that
'both stations shall set the P bit to 0'
  thanks to Alan Cox for finding this explanation in the spec

* without this fix, on Telit & Sim.com modems, opening a new DLC
randomly fails. Not setting PF bit of the control byte gives a
reliable behaviour on these modems.

Signed-off-by: default avatarEric Bénard <eric@eukrea.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 323e8412

drivers/tty/n_gsm.c

+1 −2
Original line number Diff line number Diff line
@@ -1250,8 +1250,7 @@ static void gsm_control_response(struct gsm_mux *gsm, unsigned int command, 


static void gsm_control_transmit(struct gsm_mux *gsm, struct gsm_control *ctrl)

{

	struct gsm_msg *msg = gsm_data_alloc(gsm, 0, ctrl->len + 1,

							gsm->ftype|PF);

	struct gsm_msg *msg = gsm_data_alloc(gsm, 0, ctrl->len + 1, gsm->ftype);

	if (msg == NULL)

		return;

	msg->data[0] = (ctrl->cmd << 1) | 2 | EA;	/* command */