Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ed384bd3 authored by Felipe Balbi's avatar Felipe Balbi Committed by Sarah Sharp
Browse files

usb: host: xhci: sparse fixes 



drivers/usb/host/xhci.c:1826:14: warning: symbol 'xhci_get_block_size' was not declared. Should it be static?
drivers/usb/host/xhci.c:1844:14: warning: symbol 'xhci_get_largest_overhead' was not declared. Should it be static?
drivers/usb/host/xhci-ring.c:2304:36: warning: context imbalance in 'handle_tx_event' - unexpected unlock
drivers/usb/host/xhci-hub.c:425:6: warning: symbol 'xhci_set_remote_wake_mask' was not declared. Should it be static?

Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
Signed-off-by: default avatarSarah Sharp <sarah.a.sharp@linux.intel.com>
parent b63f4053

drivers/usb/host/xhci-hub.c

+1 −1
Original line number Diff line number Diff line
@@ -422,7 +422,7 @@ void xhci_set_link_state(struct xhci_hcd *xhci, __le32 __iomem **port_array, 
	xhci_writel(xhci, temp, port_array[port_id]);

}



void xhci_set_remote_wake_mask(struct xhci_hcd *xhci,

static void xhci_set_remote_wake_mask(struct xhci_hcd *xhci,

		__le32 __iomem **port_array, int port_id, u16 wake_mask)

{

	u32 temp;

drivers/usb/host/xhci-ring.c

+2 −0
Original line number Diff line number Diff line
@@ -2273,6 +2273,8 @@ static int process_bulk_intr_td(struct xhci_hcd *xhci, struct xhci_td *td, 
 */

static int handle_tx_event(struct xhci_hcd *xhci,

		struct xhci_transfer_event *event)

	__releases(&xhci->lock)

	__acquires(&xhci->lock)

{

	struct xhci_virt_device *xdev;

	struct xhci_virt_ep *ep;

drivers/usb/host/xhci.c

+3 −2
Original line number Diff line number Diff line
@@ -1829,7 +1829,7 @@ static void xhci_finish_resource_reservation(struct xhci_hcd *xhci, 
				xhci->num_active_eps);

}



unsigned int xhci_get_block_size(struct usb_device *udev)

static unsigned int xhci_get_block_size(struct usb_device *udev)

{

	switch (udev->speed) {

	case USB_SPEED_LOW:
@@ -1847,7 +1847,8 @@ unsigned int xhci_get_block_size(struct usb_device *udev) 
	}

}



unsigned int xhci_get_largest_overhead(struct xhci_interval_bw *interval_bw)

static unsigned int

xhci_get_largest_overhead(struct xhci_interval_bw *interval_bw)

{

	if (interval_bw->overhead[LS_OVERHEAD_TYPE])

		return LS_OVERHEAD;