Commit ecc2f006 authored Jun 25, 2007 by Steve Wise Committed by Roland Dreier Jul 09, 2007

RDMA/cxgb3: Don't abort after failures sending the mpa reply



This bug results in an abort request being sent down _after_ the tid
has been released.  If the tid happens to have been reused, then the
subsequent generation of the tid gets incorrectly aborted.

The thread running iwch_accecpt_cr() must not abort a connection if an
error is returned after being awakened.  If any errors did occur while
iwch_accept_cr() is blocked, then the connection has already been
aborted on the thread processing the error.

Signed-off-by: Steve Wise <swise@opengridcomputing.com>
Signed-off-by: Roland Dreier <rolandd@cisco.com>

parent 96d0e493

drivers/infiniband/hw/cxgb3/iwch_cm.c

+0 −1

Original line number	Original line	Diff line number	Diff line
	@@ -1781,7 +1781,6 @@ err:
	ep->com.cm_id = NULL;		ep->com.cm_id = NULL;
	ep->com.qp = NULL;		ep->com.qp = NULL;
	cm_id->rem_ref(cm_id);		cm_id->rem_ref(cm_id);
	abort_connection(ep, NULL, GFP_KERNEL);
	put_ep(&ep->com);		put_ep(&ep->com);
	return err;		return err;
	}		}