Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit eba46030 authored by Arnd Hannemann's avatar Arnd Hannemann Committed by Chris Ball
Browse files

mmc: tmio_mmc: silence compiler warnings 



with "mmc: tmio: implement a bounce buffer for unaligned DMA"
gcc generates the following warnings:

drivers/mmc/host/tmio_mmc.c:654:6: warning: 'ret' may be used uninitialized in this function
drivers/mmc/host/tmio_mmc.c:730:6: warning: 'ret' may be used uninitialized in this function

This patch fixes these by setting ret to -EINVAL in the affected code paths.

Signed-off-by: default avatarArnd Hannemann <arnd@arndnet.de>
Signed-off-by: default avatarChris Ball <cjb@laptop.org>
parent 93173054

drivers/mmc/host/tmio_mmc.c

+6 −2
Original line number Diff line number Diff line
@@ -673,8 +673,10 @@ static void tmio_mmc_start_dma_rx(struct tmio_mmc_host *host) 
	}



	if ((!aligned && (host->sg_len > 1 || sg->length > PAGE_CACHE_SIZE ||

			  align >= MAX_ALIGN)) || !multiple)

			  align >= MAX_ALIGN)) || !multiple) {

		ret = -EINVAL;

		goto pio;

	}



	/* The only sg element can be unaligned, use our bounce buffer then */

	if (!aligned) {
@@ -748,8 +750,10 @@ static void tmio_mmc_start_dma_tx(struct tmio_mmc_host *host) 
	}



	if ((!aligned && (host->sg_len > 1 || sg->length > PAGE_CACHE_SIZE ||

			  align >= MAX_ALIGN)) || !multiple)

			  align >= MAX_ALIGN)) || !multiple) {

		ret = -EINVAL;

		goto pio;

	}



	/* The only sg element can be unaligned, use our bounce buffer then */

	if (!aligned) {