Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit eb6c015c authored by Takashi Iwai's avatar Takashi Iwai Committed by Sasha Levin
Browse files

ALSA: hdsp: Fix wrong boolean ctl value accesses 



[ Upstream commit eab3c4db193f5fcccf70e884de9a922ca2c63d80 ]

snd-hdsp driver accesses enum item values (int) instead of boolean
values (long) wrongly for some ctl elements.  This patch fixes them.

Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Signed-off-by: default avatarSasha Levin <sasha.levin@oracle.com>
parent cfe559b9

sound/pci/rme9652/hdsp.c

+2 −2
Original line number Diff line number Diff line
@@ -2927,7 +2927,7 @@ static int snd_hdsp_get_dds_offset(struct snd_kcontrol *kcontrol, struct snd_ctl 
{

	struct hdsp *hdsp = snd_kcontrol_chip(kcontrol);



	ucontrol->value.enumerated.item[0] = hdsp_dds_offset(hdsp);

	ucontrol->value.integer.value[0] = hdsp_dds_offset(hdsp);

	return 0;

}
@@ -2939,7 +2939,7 @@ static int snd_hdsp_put_dds_offset(struct snd_kcontrol *kcontrol, struct snd_ctl 


	if (!snd_hdsp_use_is_exclusive(hdsp))

		return -EBUSY;

	val = ucontrol->value.enumerated.item[0];

	val = ucontrol->value.integer.value[0];

	spin_lock_irq(&hdsp->lock);

	if (val != hdsp_dds_offset(hdsp))

		change = (hdsp_set_dds_offset(hdsp, val) == 0) ? 1 : 0;