Commit eb53b6db authored Apr 30, 2013 by Vyacheslav Dubeyko Committed by Linus Torvalds Apr 30, 2013

nilfs2: remove unneeded test in nilfs_writepage()



page->mapping->host cannot be NULL in nilfs_writepage(), so remove the
unneeded test.

The fixes the smatch warning: "fs/nilfs2/inode.c:211 nilfs_writepage()
error: we previously assumed 'inode' could be null (see line 195)".

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Vyacheslav Dubeyko <slava@dubeyko.com>
Cc: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent dc33f5f3

fs/nilfs2/inode.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -192,7 +192,7 @@ static int nilfs_writepage(struct page page, struct writeback_control wbc)
		struct inode *inode = page->mapping->host;
		int err;

		if (inode && (inode->i_sb->s_flags & MS_RDONLY)) {
		if (inode->i_sb->s_flags & MS_RDONLY) {
		/*
		* It means that filesystem was remounted in read-only
		* mode because of error or metadata corruption. But we