Commit eafffc0a authored Apr 24, 2017 by Pan Bian Committed by Greg Kroah-Hartman Oct 08, 2017

team: fix memory leaks




[ Upstream commit 72ec0bc64b9a5d8e0efcb717abfc757746b101b7 ]

In functions team_nl_send_port_list_get() and
team_nl_send_options_get(), pointer skb keeps the return value of
nlmsg_new(). When the call to genlmsg_put() fails, the memory is not
freed(). This will result in memory leak bugs.

Fixes: 9b00cf2d ("team: implement multipart netlink messages for options transfers")
Signed-off-by: Pan Bian <bianpan2016@163.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent fbbb384f

drivers/net/team/team.c

+6 −2

Original line number	Diff line number	Diff line
		@@ -2331,8 +2331,10 @@ start_again:

		hdr = genlmsg_put(skb, portid, seq, &team_nl_family, flags \| NLM_F_MULTI,
		TEAM_CMD_OPTIONS_GET);
		if (!hdr)
		if (!hdr) {
		nlmsg_free(skb);
		return -EMSGSIZE;
		}

		if (nla_put_u32(skb, TEAM_ATTR_TEAM_IFINDEX, team->dev->ifindex))
		goto nla_put_failure;
		@@ -2599,8 +2601,10 @@ start_again:

		hdr = genlmsg_put(skb, portid, seq, &team_nl_family, flags \| NLM_F_MULTI,
		TEAM_CMD_PORT_LIST_GET);
		if (!hdr)
		if (!hdr) {
		nlmsg_free(skb);
		return -EMSGSIZE;
		}

		if (nla_put_u32(skb, TEAM_ATTR_TEAM_IFINDEX, team->dev->ifindex))
		goto nla_put_failure;