Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit eaa591ec authored by Paulo Zanoni's avatar Paulo Zanoni Committed by Daniel Vetter
Browse files

drm/i915: fix haswell linetime watermarks calculation 



Move the "*8"  calculation to the left side so we don't propagate
rounding errors. Also use DIV_ROUND_CLOSEST because that's what the
spec says we need to do.

Signed-off-by: default avatarPaulo Zanoni <paulo.r.zanoni@intel.com>
Reviewed-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
parent 73669373

drivers/gpu/drm/i915/intel_pm.c

+1 −1
Original line number Diff line number Diff line
@@ -2093,7 +2093,7 @@ haswell_update_linetime_wm(struct drm_device *dev, struct drm_crtc *crtc) 
	 * row at the given clock rate, multiplied by 8.

	 * */

	temp |= PIPE_WM_LINETIME_TIME(

		((mode->htotal * 1000) / mode->clock) * 8);

		DIV_ROUND_CLOSEST(mode->htotal * 1000 * 8, mode->clock));



	/* IPS watermarks are only used by pipe A, and are ignored by

	 * pipes B and C.  They are calculated similarly to the common