Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e7051b40 authored by Colin Cross's avatar Colin Cross Committed by Ruchi Kandoi
Browse files

debug: add parameters to prevent entering debug mode on errors 



On non-developer devices kgdb prevents CONFIG_PANIC_TIMEOUT from
rebooting the device after a panic. Add module parameters
debug_core.break_on_exception and debug_core.break_on_panic to
allow skipping debug on panics and exceptions respectively.  Both
default to true to preserve existing behavior.

Change-Id: I75dce7263e96cee069a9750920cce83dc6f98e8c
Signed-off-by: default avatarColin Cross <ccross@android.com>
parent 8bbe0d9f

kernel/debug/debug_core.c

+12 −0
Original line number Diff line number Diff line
@@ -87,6 +87,10 @@ static int kgdb_use_con; 
bool dbg_is_early = true;

/* Next cpu to become the master debug core */

int dbg_switch_cpu;

/* Flag for entering kdb when a panic occurs */

static bool break_on_panic = true;

/* Flag for entering kdb when an exception occurs */

static bool break_on_exception = true;



/* Use kdb or gdbserver mode */

int dbg_kdb_mode = 1;
@@ -101,6 +105,8 @@ early_param("kgdbcon", opt_kgdb_con); 


module_param(kgdb_use_con, int, 0644);

module_param(kgdbreboot, int, 0644);

module_param(break_on_panic, bool, 0644);

module_param(break_on_exception, bool, 0644);



/*

 * Holds information about breakpoints in a kernel. These breakpoints are
@@ -690,6 +696,9 @@ kgdb_handle_exception(int evector, int signo, int ecode, struct pt_regs *regs) 
	if (arch_kgdb_ops.enable_nmi)

		arch_kgdb_ops.enable_nmi(0);



	if (unlikely(signo != SIGTRAP && !break_on_exception))

		return 1;



	memset(ks, 0, sizeof(struct kgdb_state));

	ks->cpu			= raw_smp_processor_id();

	ks->ex_vector		= evector;
@@ -821,6 +830,9 @@ static int kgdb_panic_event(struct notifier_block *self, 
			    unsigned long val,

			    void *data)

{

	if (!break_on_panic)

		return NOTIFY_DONE;



	if (dbg_kdb_mode)

		kdb_printf("PANIC: %s\n", (char *)data);

	kgdb_breakpoint();