Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e6a52030 authored by Amitkumar Karwar's avatar Amitkumar Karwar Committed by John W. Linville
Browse files

mwifiex: code rearrangement in mwifiex_get_rd_port() 



Get rid of 'if else' usage by returning in 'if' block.
This improves readability by removing indentations.

Signed-off-by: default avatarAmitkumar Karwar <akarwar@marvell.com>
Signed-off-by: default avatarBing Zhao <bzhao@marvell.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent ab93d4ff

drivers/net/wireless/mwifiex/sdio.c

+15 −14
Original line number Diff line number Diff line
@@ -512,22 +512,23 @@ static int mwifiex_get_rd_port(struct mwifiex_adapter *adapter, u8 *port) 
		*port = CTRL_PORT;

		dev_dbg(adapter->dev, "data: port=%d mp_rd_bitmap=0x%08x\n",

			*port, card->mp_rd_bitmap);

	} else {

		if (card->mp_rd_bitmap & (1 << card->curr_rd_port)) {

			card->mp_rd_bitmap &= (u32)

						(~(1 << card->curr_rd_port));

		return 0;

	}



	if (!(card->mp_rd_bitmap & (1 << card->curr_rd_port)))

		return -1;



	/* We are now handling the SDIO data ports */

	card->mp_rd_bitmap &= (u32)(~(1 << card->curr_rd_port));

	*port = card->curr_rd_port;



	if (++card->curr_rd_port == card->max_ports)

		card->curr_rd_port = reg->start_rd_port;

		} else {

			return -1;

		}



	dev_dbg(adapter->dev,

		"data: port=%d mp_rd_bitmap=0x%08x -> 0x%08x\n",

		*port, rd_bitmap, card->mp_rd_bitmap);

	}



	return 0;

}