Commit e6985c7f authored Jun 04, 2007 by Akinobu Mita Committed by Steve French Jun 04, 2007

[CIFS] fix mempool destroy done in wrong order in cifs error path



Slab cache used as memory pool can not be destroyed before the memory
pool destruction. Because the memory pool still holds some objects and
kmem_cache_destroy() says "Can't free all objects".

Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Signed-off-by: Steve French <sfrench@us.ibm.com>

parent f7f7c31c

fs/cifs/cifsfs.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -825,8 +825,8 @@ cifs_init_mids(void)
		sizeof (struct oplock_q_entry), 0,
		SLAB_HWCACHE_ALIGN, NULL, NULL);
		if (cifs_oplock_cachep == NULL) {
		kmem_cache_destroy(cifs_mid_cachep);
		mempool_destroy(cifs_mid_poolp);
		kmem_cache_destroy(cifs_mid_cachep);
		return -ENOMEM;
		}