Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e55fea0c authored by Dan Carpenter's avatar Dan Carpenter Committed by Wolfram Sang
Browse files

i2c: scmi: remove some bogus NULL checks 



"obj" can't be NULL here.

We already know that "pkg->package.elements" gives us a valid pointer
so the next pointer after that is also non-NULL.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarWolfram Sang <wsa@the-dreams.de>
parent 5edb1062

drivers/i2c/busses/i2c-scmi.c

+3 −3
Original line number Diff line number Diff line
@@ -223,7 +223,7 @@ acpi_smbus_cmi_access(struct i2c_adapter *adap, u16 addr, unsigned short flags, 
		goto out;



	obj = pkg->package.elements + 1;

	if (obj == NULL || obj->type != ACPI_TYPE_INTEGER) {

	if (obj->type != ACPI_TYPE_INTEGER) {

		ACPI_ERROR((AE_INFO, "Invalid argument type"));

		result = -EIO;

		goto out;
@@ -235,7 +235,7 @@ acpi_smbus_cmi_access(struct i2c_adapter *adap, u16 addr, unsigned short flags, 
	case I2C_SMBUS_BYTE:

	case I2C_SMBUS_BYTE_DATA:

	case I2C_SMBUS_WORD_DATA:

		if (obj == NULL || obj->type != ACPI_TYPE_INTEGER) {

		if (obj->type != ACPI_TYPE_INTEGER) {

			ACPI_ERROR((AE_INFO, "Invalid argument type"));

			result = -EIO;

			goto out;
@@ -246,7 +246,7 @@ acpi_smbus_cmi_access(struct i2c_adapter *adap, u16 addr, unsigned short flags, 
			data->byte = obj->integer.value;

		break;

	case I2C_SMBUS_BLOCK_DATA:

		if (obj == NULL || obj->type != ACPI_TYPE_BUFFER) {

		if (obj->type != ACPI_TYPE_BUFFER) {

			ACPI_ERROR((AE_INFO, "Invalid argument type"));

			result = -EIO;

			goto out;