Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e534e871 authored by Tony Lindgren's avatar Tony Lindgren
Browse files

ARM: OMAP4: Fix array size for irq_target_cpu 



If NR_IRQS is less than MAX_IRQS, we end up writing past the
irq_target_cpu array in omap_wakeupgen_init():

/* Associate all the IRQs to boot CPU like GIC init does. */
for (i = 0; i < max_irqs; i++)
	irq_target_cpu[i] = boot_cpu;

This can happen if SPARSE_IRQ is enabled as by default NR_IRQS is
set to 16. Without this patch we're overwriting other data during
the boot.

Looks like a similar fix was posted by Benoit Cousson earlier
as "ARM: OMAP2+: wakeupgen: Fix wrong array size for irq_target_cpu"
but was lost.

Cc: stable@vger.kernel.org
Acked-by: default avatarSantosh Shilimkar <santosh.shilimkar@ti.com>
Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
parent 4cbe5a55

arch/arm/mach-omap2/omap-wakeupgen.c

+1 −1
Original line number Diff line number Diff line
@@ -46,7 +46,7 @@ 
static void __iomem *wakeupgen_base;

static void __iomem *sar_base;

static DEFINE_SPINLOCK(wakeupgen_lock);

static unsigned int irq_target_cpu[NR_IRQS];

static unsigned int irq_target_cpu[MAX_IRQS];

static unsigned int irq_banks = MAX_NR_REG_BANKS;

static unsigned int max_irqs = MAX_IRQS;

static unsigned int omap_secure_apis;