Commit e481fcf8 authored Mar 19, 2008 by Glauber de Oliveira Costa Committed by Ingo Molnar Apr 17, 2008

x86: calibrate delay with irqs enabled



We do it to make it close to x86_64. The later needs it,
otherwise the nmi watchdog can get into the scene and kill us
with a hammer.

Enabling irqs here used to trigger a bug in i386. This is because
time irq handling relies upon structures that are only initialized
after smp initcalls (More precisely, it will find
per_cpu(hrtimer_bases, cpu)->cb_pending list not initialized and crash)

Signed-off-by: Glauber Costa <gcosta@redhat.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>

parent ac60aae5

arch/x86/kernel/smpboot_32.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -167,7 +167,9 @@ static void __cpuinit smp_callin(void)
		/*
		* Get our bogomips.
		*/
		local_irq_enable();
		calibrate_delay();
		local_irq_disable();
		Dprintk("Stack at about %p\n",&cpuid);

		/*