Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e472ba15 authored by Tetsuo Handa's avatar Tetsuo Handa Committed by Greg Kroah-Hartman
Browse files

PM / hibernate: Fix oops at snapshot_write() 

commit fc14eebfc20854a38fd9f1d93a42b1783dad4d17 upstream.

syzbot is reporting NULL pointer dereference at snapshot_write() [1].
This is because data->handle is zero-cleared by ioctl(SNAPSHOT_FREE).
Fix this by checking data_of(data->handle) != NULL before using it.

[1] https://syzkaller.appspot.com/bug?id=828a3c71bd344a6de8b6a31233d51a72099f27fd



Signed-off-by: default avatarTetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Reported-by: default avatarsyzbot <syzbot+ae590932da6e45d6564d@syzkaller.appspotmail.com>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 316a8013

kernel/power/user.c

+5 −0
Original line number Diff line number Diff line
@@ -184,6 +184,11 @@ static ssize_t snapshot_write(struct file *filp, const char __user *buf, 
		res = PAGE_SIZE - pg_offp;

	}



	if (!data_of(data->handle)) {

		res = -EINVAL;

		goto unlock;

	}



	res = simple_write_to_buffer(data_of(data->handle), res, &pg_offp,

			buf, count);

	if (res > 0)