Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e3e45c01 authored by Stephane Eranian's avatar Stephane Eranian Committed by Ingo Molnar
Browse files

perf/x86: Fix microcode revision check for SNB-PEBS 



The following patch makes the microcode update code path
actually invoke the perf_check_microcode() function and
thus potentially renabling SNB PEBS.

By default, CONFIG_MICROCODE_OLD_INTERFACE is
forced to Y in arch/x86/Kconfig. There is no
way to disable this. That means that the code
path used in arch/x86/kernel/microcode_core.c
did not include the call to perf_check_microcode().

Thus, even though the microcode was updated to a
version that fixes the SNB PEBS problem, perf_event
would still return EOPNOTSUPP when enabling precise
sampling.

This patch simply adds a call to perf_check_microcode()
in the call path used when OLD_INTERFACE=y.

Signed-off-by: default avatarStephane Eranian <eranian@google.com>
Acked-by: default avatarBorislav Petkov <borislav.petkov@amd.com>
Cc: peterz@infradead.org
Cc: andi@firstfloor.org
Link: http://lkml.kernel.org/r/20120824133434.GA8014@quad


Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
parent 9acb1725

arch/x86/kernel/microcode_core.c

+3 −0
Original line number Diff line number Diff line
@@ -225,6 +225,9 @@ static ssize_t microcode_write(struct file *file, const char __user *buf, 
	if (do_microcode_update(buf, len) == 0)

		ret = (ssize_t)len;



	if (ret > 0)

		perf_check_microcode();



	mutex_unlock(&microcode_mutex);

	put_online_cpus();