Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e3d2e433 authored by Ashish Sangwan's avatar Ashish Sangwan Committed by Theodore Ts'o
Browse files

ext4: no need to add inode to orphan list during hole punch 



While performing punch hole for an inode, i_disksize is not changed.
So, there is no need to add the inode to orphan list.

Signed-off-by: default avatarAshish Sangwan <ashish.sangwan2@gmail.com>
Signed-off-by: default avatarNamjae Jeon <linkinjeon@gmail.com>
Acked-by: default avatarZheng Liu <wenqing.lz@taobao.com>
Signed-off-by: default avatar"Theodore Ts'o" <tytso@mit.edu>
parent eeecef0a

fs/ext4/extents.c

+0 −4
Original line number Diff line number Diff line
@@ -4860,9 +4860,6 @@ int ext4_ext_punch_hole(struct file *file, loff_t offset, loff_t length) 
	if (IS_ERR(handle))

		return PTR_ERR(handle);



	err = ext4_orphan_add(handle, inode);

	if (err)

		goto out;



	/*

	 * Now we need to zero out the non-page-aligned data in the
@@ -4948,7 +4945,6 @@ int ext4_ext_punch_hole(struct file *file, loff_t offset, loff_t length) 
	up_write(&EXT4_I(inode)->i_data_sem);



out:

	ext4_orphan_del(handle, inode);

	inode->i_mtime = inode->i_ctime = ext4_current_time(inode);

	ext4_mark_inode_dirty(handle, inode);

	ext4_journal_stop(handle);