Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e363a755 authored by Alan Jenkins's avatar Alan Jenkins Committed by Len Brown
Browse files

ACPI: battery: Fix CONFIG_ACPI_SYSFS_POWER=n



Disabling CONFIG_ACPI_SYSFS_POWER changes the behaviour of
acpi_battery_update().  It will call acpi_battery_get_info()
even if the battery is not present.  I haven't noticed this
causing any problem, but it does look like a bad idea.

Signed-off-by: default avatarAlan Jenkins <alan-jenkins@tuffmail.co.uk>
Acked-by: default avatarAlexey Starikovskiy <astarikovskiy@suse.de>
Signed-off-by: default avatarLen Brown <len.brown@intel.com>
parent 2eaa9cfd
Loading
Loading
Loading
Loading
+2 −2
Original line number Diff line number Diff line
@@ -567,13 +567,13 @@ static int acpi_battery_update(struct acpi_battery *battery)
	result = acpi_battery_get_status(battery);
	if (result)
		return result;
#ifdef CONFIG_ACPI_SYSFS_POWER
	if (!acpi_battery_present(battery)) {
#ifdef CONFIG_ACPI_SYSFS_POWER
		sysfs_remove_battery(battery);
#endif
		battery->update_time = 0;
		return 0;
	}
#endif
	if (!battery->update_time ||
	    old_present != acpi_battery_present(battery)) {
		result = acpi_battery_get_info(battery);