Commit e360fb08 authored Oct 09, 2015 by Russell King Committed by Sasha Levin Nov 13, 2015

crypto: ahash - ensure statesize is non-zero



[ Upstream commit 8996eafdcbad149ac0f772fb1649fbb75c482a6a ]

Unlike shash algorithms, ahash drivers must implement export
and import as their descriptors may contain hardware state and
cannot be exported as is.  Unfortunately some ahash drivers did
not provide them and end up causing crashes with algif_hash.

This patch adds a check to prevent these drivers from registering
ahash algorithms until they are fixed.

Cc: stable@vger.kernel.org
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>

parent d9d554c9

crypto/ahash.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -543,7 +543,8 @@ static int ahash_prepare_alg(struct ahash_alg *alg)
		struct crypto_alg *base = &alg->halg.base;

		if (alg->halg.digestsize > PAGE_SIZE / 8 \|\|
		alg->halg.statesize > PAGE_SIZE / 8)
		alg->halg.statesize > PAGE_SIZE / 8 \|\|
		alg->halg.statesize == 0)
		return -EINVAL;

		base->cra_type = &crypto_ahash_type;