Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e34132f4 authored by Mike Frysinger's avatar Mike Frysinger
Browse files

Blackfin: reject NULL callback in set_dma_callback() 



It makes no sense to call this function with a NULL callback.

Signed-off-by: default avatarMike Frysinger <vapier@gentoo.org>
parent f69b2d7e

arch/blackfin/kernel/bfin_dma_5xx.c

+10 −11
Original line number Original line Diff line number Diff line
@@ -138,21 +138,20 @@ EXPORT_SYMBOL(request_dma); 




int set_dma_callback(unsigned int channel, irq_handler_t callback, void *data)

int set_dma_callback(unsigned int channel, irq_handler_t callback, void *data)

{

{

	BUG_ON(channel >= MAX_DMA_CHANNELS ||

			!atomic_read(&dma_ch[channel].chan_status));



	if (callback != NULL) {

	int ret;

	int ret;

		unsigned int irq = channel2irq(channel);

	unsigned int irq;





		ret = request_irq(irq, callback, IRQF_DISABLED,

	BUG_ON(channel >= MAX_DMA_CHANNELS || !callback ||

			dma_ch[channel].device_id, data);

			!atomic_read(&dma_ch[channel].chan_status));



	irq = channel2irq(channel);

	ret = request_irq(irq, callback, 0, dma_ch[channel].device_id, data);

	if (ret)

	if (ret)

		return ret;

		return ret;





	dma_ch[channel].irq = irq;

	dma_ch[channel].irq = irq;

	dma_ch[channel].data = data;

	dma_ch[channel].data = data;

	}



	return 0;

	return 0;

}

}

EXPORT_SYMBOL(set_dma_callback);

EXPORT_SYMBOL(set_dma_callback);