Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e333b3ed authored by Gerrit Renker's avatar Gerrit Renker Committed by David S. Miller
Browse files

[DCCP]: Promote CCID2 as default CCID 



This patch addresses the following problems:

 1. DCCP relies for its proper functioning on having at least one CCID module
    enabled (as in TCP plugable congestion control). Currently it is possible to
    disable both CCIDs and thus leave the DCCP module in a compiled, but entirely
    non-functional state: no sockets can be created when no CCID is available.
    Furthermore, the protocol is (again like TCP) not intended to be used without
    CCIDs. Last, a non-empty CCID list is needed for doing CCID feature negotiation.

 2. Internally the default CCID that is advertised by the Linux host is set to CCID2
    (DCCPF_INITIAL_CCID in include/linux/dccp.h). Disabling CCID2 in the Kconfig
    menu without changing the defaults leads to a failure `module not found' when
    trying to load the dccp module (which internally tries to load the default CCID).

 3. The specification (RFC 4340, sec. 10) treats CCID2 somewhat like a
    `minimum common denominator'; the specification says that:

    * "New connections start with CCID 2 for both endpoints"

    * "A DCCP implementation intended for general use, such as an implementation in a
       general-purpose operating system kernel, SHOULD implement at least CCID 2.
       The intent is to make CCID 2 broadly available for interoperability [...]"

    Providing CCID2 as minimum-required CCID (like Reno/Cubic in TCP) thus seems reasonable.

Hence this patch automatically selects CCID2 when DCCP is enabled. Documentation also added.

Discussions with Ian McDonald on this subject are gratefully acknowledged.

Signed-off-by: default avatarGerrit Renker <gerrit@erg.abdn.ac.uk>
Signed-off-by: default avatarIan McDonald <ian.mcdonald@jandi.co.nz>
Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent ebe6f7e7

Documentation/networking/dccp.txt

+9 −2
Original line number Original line Diff line number Diff line
@@ -14,8 +14,15 @@ Introduction 
============

============





Datagram Congestion Control Protocol (DCCP) is an unreliable, connection

Datagram Congestion Control Protocol (DCCP) is an unreliable, connection

based protocol designed to solve issues present in UDP and TCP particularly

oriented protocol designed to solve issues present in UDP and TCP, particularly

for real time and multimedia traffic.

for real-time and multimedia (streaming) traffic.

It divides into a base protocol (RFC 4340) and plugable congestion control

modules called CCIDs. Like plugable TCP congestion control, at least one CCID

needs to be enabled in order for the protocol to function properly. In the Linux

implementation, this is the TCP-like CCID2 (RFC 4341). Additional CCIDs, such as

the TCP-friendly CCID3 (RFC 4342), are optional.

For a brief introduction to CCIDs and suggestions for choosing a CCID to match

given applications, see section 10 of RFC 4340.





It has a base protocol and pluggable congestion control IDs (CCIDs).

It has a base protocol and pluggable congestion control IDs (CCIDs).

net/dccp/Kconfig

+1 −0
Original line number Original line Diff line number Diff line 
menuconfig IP_DCCP

menuconfig IP_DCCP

	tristate "The DCCP Protocol (EXPERIMENTAL)"

	tristate "The DCCP Protocol (EXPERIMENTAL)"

	depends on INET && EXPERIMENTAL

	depends on INET && EXPERIMENTAL

	select IP_DCCP_CCID2

	---help---

	---help---

	  Datagram Congestion Control Protocol (RFC 4340)

	  Datagram Congestion Control Protocol (RFC 4340)

net/dccp/ccids/Kconfig

+2 −11
Original line number Original line Diff line number Diff line
@@ -20,18 +20,9 @@ config IP_DCCP_CCID2 
	  to the user.  For example, a hypothetical application that

	  to the user.  For example, a hypothetical application that

	  transferred files over DCCP, using application-level retransmissions

	  transferred files over DCCP, using application-level retransmissions

	  for lost packets, would prefer CCID 2 to CCID 3.  On-line games may

	  for lost packets, would prefer CCID 2 to CCID 3.  On-line games may

	  also prefer CCID 2.

	  also prefer CCID 2.  See RFC 4341 for further details.





	  CCID 2 is further described in RFC 4341,

	  CCID2 is the default CCID used by DCCP.

	  http://www.ietf.org/rfc/rfc4341.txt



	  This text was extracted from RFC 4340 (sec. 10.1),

	  http://www.ietf.org/rfc/rfc4340.txt



	  To compile this CCID as a module, choose M here: the module will be

	  called dccp_ccid2.



	  If in doubt, say M.





config IP_DCCP_CCID2_DEBUG

config IP_DCCP_CCID2_DEBUG

	  bool "CCID2 debugging messages"

	  bool "CCID2 debugging messages"