Commit e23e1179 authored Feb 02, 2010 by Roel Kluin Committed by David S. Miller Feb 03, 2010

hisax: timeout off by one in waitrecmsg()



With `while (timeout++ < maxdelay)' timeout reaches maxdelay + 1 after the
loop This is probably unlikely a problem in practice.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Cc: Karsten Keil <isdn@linux-pingi.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 4bbd1a19

drivers/isdn/hisax/isar.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -138,7 +138,7 @@ waitrecmsg(struct IsdnCardState cs, u_char len,
		while((!(cs->BC_Read_Reg(cs, 0, ISAR_IRQBIT) & ISAR_IRQSTA)) &&
		(timeout++ < maxdelay))
		udelay(1);
		if (timeout >= maxdelay) {
		if (timeout > maxdelay) {
		printk(KERN_WARNING"isar recmsg IRQSTA timeout\n");
		return(0);
		}