Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e0c5567d authored by roel kluin's avatar roel kluin Committed by David S. Miller
Browse files

atm: Cleanup redundant tests on unsigned 



The variables are unsigned so the `< 0' test always fails, the
other part of the test catches wrapped values.

Signed-off-by: default avatarRoel Kluin <roel.kluin@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 65a1c4ff

drivers/atm/fore200e.c

+2 −2
Original line number Diff line number Diff line
@@ -2906,7 +2906,7 @@ fore200e_proc_read(struct atm_dev *dev, loff_t* pos, char* page) 
	u32 media_index    = FORE200E_MEDIA_INDEX(fore200e->bus->read(&fore200e->cp_queues->media_type));

	u32 oc3_index;



	if ((media_index < 0) || (media_index > 4))

	if (media_index > 4)

		media_index = 5;

	

	switch (fore200e->loop_mode) {

drivers/atm/he.c

+1 −1
Original line number Diff line number Diff line
@@ -2739,7 +2739,7 @@ he_ioctl(struct atm_dev *atm_dev, unsigned int cmd, void __user *arg) 
			spin_lock_irqsave(&he_dev->global_lock, flags);

			switch (reg.type) {

				case HE_REGTYPE_PCI:

					if (reg.addr < 0 || reg.addr >= HE_REGMAP_SIZE) {

					if (reg.addr >= HE_REGMAP_SIZE) {

						err = -EINVAL;

						break;

					}