Commit e0044c98 authored Mar 11, 2013 by Dan Carpenter Committed by Jeff Garzik Apr 03, 2013

pata_legacy: bogus clock in opti82c46x_set_piomode()



"sysclk" is used as an index into a 4 element array.  My static
checker complains because it can be out of bounds.  From the
context, it looks like there is a right bit shift missing.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>

parent bdfa2e7e

drivers/ata/pata_legacy.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -542,7 +542,7 @@ static void opti82c46x_set_piomode(struct ata_port ap, struct ata_device adev)
		u8 sysclk;

		/* Get the clock */
		sysclk = opti_syscfg(0xAC) & 0xC0; /* BIOS set */
		sysclk = (opti_syscfg(0xAC) & 0xC0) >> 6; /* BIOS set */

		/* Enter configuration mode */
		ioread16(ap->ioaddr.error_addr);