Commit df7e1303 authored Apr 20, 2011 by Jan Kara Committed by Linus Torvalds Apr 21, 2011

vfs: Pass setxattr(2) flags properly



For some reason generic_setxattr() did not pass flags (XATTR_CREATE,
XATTR_REPLACE) to the filesystem specific helper. This caused that
setxattr(2) syscall just ignored these flags.

Fix the bug by passing flags correctly.

Signed-off-by: Jan Kara <jack@suse.cz>
Acked-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 584f7904

fs/xattr.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -666,7 +666,7 @@ generic_setxattr(struct dentry dentry, const char name, const void *value, siz
		handler = xattr_resolve_name(dentry->d_sb->s_xattr, &name);
		if (!handler)
		return -EOPNOTSUPP;
		return handler->set(dentry, name, value, size, 0, handler->flags);
		return handler->set(dentry, name, value, size, flags, handler->flags);
		}

		/*