Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit df1b86c5 authored by Pavel Emelyanov's avatar Pavel Emelyanov Committed by David S. Miller
Browse files

[NET]: Nicer WARN_ON in netstat_show 



The

        if (statement)
                WARN_ON(1);

looks much better as

        WARN_ON(statement);

Signed-off-by: default avatarPavel Emelyanov <xemul@openvz.org>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c7dc89c0

net/core/net-sysfs.c

+2 −3
Original line number Diff line number Diff line
@@ -247,9 +247,8 @@ static ssize_t netstat_show(const struct device *d, 
	struct net_device_stats *stats;

	ssize_t ret = -EINVAL;



	if (offset > sizeof(struct net_device_stats) ||

	    offset % sizeof(unsigned long) != 0)

		WARN_ON(1);

	WARN_ON(offset > sizeof(struct net_device_stats) ||

			offset % sizeof(unsigned long) != 0);



	read_lock(&dev_base_lock);

	if (dev_isalive(dev) && dev->get_stats &&