Commit dec08a83 authored Sep 19, 2012 by Michael Wang Committed by Ingo Molnar Sep 26, 2012

x86: Remove the useless branch in c_start()



Since 'cpu == -1' in cpumask_next() is legal, no need to handle
'*pos == 0' specially.

About the comments:

	/* just in case, cpu 0 is not the first */

A test with a cpumask in which cpu 0 is not the first has been
done, and it works well.

This patch will remove that useless branch to clean the code.

Signed-off-by: Michael Wang <wangyun@linux.vnet.ibm.com>
Cc: kjwinchester@gmail.com
Cc: borislav.petkov@amd.com
Cc: ak@linux.intel.com
Link: http://lkml.kernel.org/r/1348033343-23658-1-git-send-email-wangyun@linux.vnet.ibm.com


Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent 6f0f9b6b

arch/x86/kernel/cpu/proc.c

+1 −4

Original line number	Diff line number	Diff line
		@@ -140,9 +140,6 @@ static int show_cpuinfo(struct seq_file m, void v)

		static void c_start(struct seq_file m, loff_t *pos)
		{
		if (pos == 0) / just in case, cpu 0 is not the first */
		*pos = cpumask_first(cpu_online_mask);
		else
		pos = cpumask_next(pos - 1, cpu_online_mask);
		if ((*pos) < nr_cpu_ids)
		return &cpu_data(*pos);