Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit de81d402 authored by Vijayavardhan Vennapusa's avatar Vijayavardhan Vennapusa
Browse files

USB: dwc3: debugfs: Add boundary check in dwc3_store_ep_num() 



User can pass arguments as part of write to requests and endpoint number
will be calculated based on the arguments. There is a chance that driver
can access ep structue that is not allocated due to invalid arguments
passed by user. Hence fix the issue by having check and return error in
case of invalid arguments.

Change-Id: I060ea878b55ce0f9983b91c50e58718c8a2c2fa1
Signed-off-by: default avatarVijayavardhan Vennapusa <vvreddy@codeaurora.org>
parent b2b64139

drivers/usb/dwc3/debugfs.c

+10 −2
Original line number Diff line number Diff line
@@ -630,7 +630,7 @@ static ssize_t dwc3_store_ep_num(struct file *file, const char __user *ubuf, 
	struct seq_file		*s = file->private_data;

	struct dwc3		*dwc = s->private;

	char			kbuf[10];

	unsigned int		num, dir;

	unsigned int		num, dir, temp;

	unsigned long		flags;



	memset(kbuf, 0, 10);
@@ -641,8 +641,16 @@ static ssize_t dwc3_store_ep_num(struct file *file, const char __user *ubuf, 
	if (sscanf(kbuf, "%u %u", &num, &dir) != 2)

		return -EINVAL;



	if (dir != 0 && dir != 1)

		return -EINVAL;



	temp = (num << 1) + dir;

	if (temp >= (dwc->num_in_eps + dwc->num_out_eps) ||

					temp >= DWC3_ENDPOINTS_NUM)

		return -EINVAL;



	spin_lock_irqsave(&dwc->lock, flags);

	ep_num = (num << 1) + dir;

	ep_num = temp;

	spin_unlock_irqrestore(&dwc->lock, flags);



	return count;