Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit de69113e authored by Axel Lin's avatar Axel Lin Committed by James Morris
Browse files

TPM: tpm_nsc: Fix a double free of pdev in cleanup_nsc 



platform_device_unregister() will release all resources
and remove it from the subsystem, then drop reference count by
calling platform_device_put().

We should not call kfree(pdev) after platform_device_unregister(pdev).

Signed-off-by: default avatarAxel Lin <axel.lin@gmail.com>
Signed-off-by: default avatarRajiv Andrade <srajiv@linux.vnet.ibm.com>
Signed-off-by: default avatarJames Morris <jmorris@namei.org>
parent 5ce5ed35

drivers/char/tpm/tpm_nsc.c

+0 −2
Original line number Diff line number Diff line
@@ -396,8 +396,6 @@ static void __exit cleanup_nsc(void) 
	if (pdev) {

		tpm_nsc_remove(&pdev->dev);

		platform_device_unregister(pdev);

		kfree(pdev);

		pdev = NULL;

	}



	platform_driver_unregister(&nsc_drv);