Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit de1e0c40 authored by Dan Carpenter's avatar Dan Carpenter Committed by Linus Torvalds
Browse files

fanotify: info leak in copy_event_to_user() 



The ->reserved field isn't cleared so we leak one byte of stack
information to userspace.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Cc: Eric Paris <eparis@redhat.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent b9ce54c9

fs/notify/fanotify/fanotify_user.c

+1 −0
Original line number Diff line number Diff line
@@ -122,6 +122,7 @@ static int fill_event_metadata(struct fsnotify_group *group, 
	metadata->event_len = FAN_EVENT_METADATA_LEN;

	metadata->metadata_len = FAN_EVENT_METADATA_LEN;

	metadata->vers = FANOTIFY_METADATA_VERSION;

	metadata->reserved = 0;

	metadata->mask = event->mask & FAN_ALL_OUTGOING_EVENTS;

	metadata->pid = pid_vnr(event->tgid);

	if (unlikely(event->mask & FAN_Q_OVERFLOW))