Commit dda804ad authored Sep 15, 2010 by Nishanth Aravamudan Committed by Benjamin Herrenschmidt Oct 13, 2010

powerpc/pci: Fix return type of BUID_{HI,LO} macros



BUID_HI and BUID_LO are used to pass data to call_rtas, which expects
ints or u32s. But the macro doesn't cast the return, so the result is
still u64. Use the upper_32_bits and lower_32_bits macros that have been
added to kernel.h.

Found by getting printf format errors trying to debug print the args, no
actual code change for 64 bit kernels where the macros are actually
used.

Signed-off-by: Milton Miller <miltonm@bga.com>
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
Acked-by: Linas Vepstas <linasvepstas@gmail.com>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>

parent 80322143

arch/powerpc/include/asm/ppc-pci.h

+2 −2

Original line number	Diff line number	Diff line
		@@ -28,8 +28,8 @@ extern void find_and_init_phbs(void);
		extern struct pci_dev isa_bridge_pcidev; / may be NULL if no ISA bus */

		/** Bus Unit ID macros; get low and hi 32-bits of the 64-bit BUID */
		#define BUID_HI(buid) ((buid) >> 32)
		#define BUID_LO(buid) ((buid) & 0xffffffff)
		#define BUID_HI(buid) upper_32_bits(buid)
		#define BUID_LO(buid) lower_32_bits(buid)

		/* PCI device_node operations */
		struct device_node;