Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dd1589a4 authored by David Howells's avatar David Howells Committed by David S. Miller
Browse files

Bluetooth: Fix abuse of the preincrement operator 



Fix abuse of the preincrement operator as detected when building with gcc
4.6.0:

	 CC [M]  drivers/bluetooth/hci_bcsp.o
	drivers/bluetooth/hci_bcsp.c: In function 'bcsp_prepare_pkt':
	drivers/bluetooth/hci_bcsp.c:247:20: warning: operation on 'bcsp->msgq_txseq' may be undefined

Reported-by: default avatarJustin P. Mattock <justinmattock@gmail.com>
Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
Acked-by: default avatarGustavo F. Padovan <padovan@profusion.mobi>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 9b2c2ff7

drivers/bluetooth/hci_bcsp.c

+1 −1
Original line number Diff line number Diff line
@@ -244,7 +244,7 @@ static struct sk_buff *bcsp_prepare_pkt(struct bcsp_struct *bcsp, u8 *data, 
	if (rel) {

		hdr[0] |= 0x80 + bcsp->msgq_txseq;

		BT_DBG("Sending packet with seqno %u", bcsp->msgq_txseq);

		bcsp->msgq_txseq = ++(bcsp->msgq_txseq) & 0x07;

		bcsp->msgq_txseq = (bcsp->msgq_txseq + 1) & 0x07;

	}



	if (bcsp->use_crc)