Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dcb3a08e authored by Jiri Slaby's avatar Jiri Slaby Committed by Linus Torvalds
Browse files

Documentation: configfs examples crash fix 



When configfs_register_subsystem() fails, we unregister too many
subsystems in configfs_example_init.  Decrement i by one to not unregister
non-registered subsystem.

[akpm@linux-foundation.org: coding-style fixes]
Signed-off-by: default avatarJiri Slaby <jslaby@suse.cz>
Cc: Joel Becker <joel.becker@oracle.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 02d54f09

Documentation/filesystems/configfs/configfs_example_explicit.c

+2 −4
Original line number Diff line number Diff line
@@ -464,9 +464,8 @@ static int __init configfs_example_init(void) 
	return 0;



out_unregister:

	for (; i >= 0; i--) {

	for (i--; i >= 0; i--)

		configfs_unregister_subsystem(example_subsys[i]);

	}



	return ret;

}
@@ -475,10 +474,9 @@ static void __exit configfs_example_exit(void) 
{

	int i;



	for (i = 0; example_subsys[i]; i++) {

	for (i = 0; example_subsys[i]; i++)

		configfs_unregister_subsystem(example_subsys[i]);

}

}



module_init(configfs_example_init);

module_exit(configfs_example_exit);

Documentation/filesystems/configfs/configfs_example_macros.c

+2 −4
Original line number Diff line number Diff line
@@ -427,9 +427,8 @@ static int __init configfs_example_init(void) 
	return 0;



out_unregister:

	for (; i >= 0; i--) {

	for (i--; i >= 0; i--)

		configfs_unregister_subsystem(example_subsys[i]);

	}



	return ret;

}
@@ -438,10 +437,9 @@ static void __exit configfs_example_exit(void) 
{

	int i;



	for (i = 0; example_subsys[i]; i++) {

	for (i = 0; example_subsys[i]; i++)

		configfs_unregister_subsystem(example_subsys[i]);

}

}



module_init(configfs_example_init);

module_exit(configfs_example_exit);